New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to profile archiving #12935
Comments
Is it required to have two modes |
The thing is that you want to profile the archiving but not have any logs visible in the UI and you need to ensure in "web" the profiling won't be activated. |
If the logs are made w/ |
Here it is less about the log level as we don't want to have any other output with "info" level logged to the CLI output. It was really meant to only enable specific profiling messages but not any other log messages that may be suppressed because of the log level. What I need is basically a possibility to see some profiling information in the CLI output of the archiver when enabled. But those messages should not be shown in the UI in any way. We already have Hope that makes it a bit more clear. |
I still don't see the need for |
The default log level is Those profiling messages could be logged as |
But that's to the UI, no? For the CLI the log level should be INFO.
Ok, then to my understanding the requirement is to display these in the CLI output for core:archive when enabled, but never in the UI (correct me if I'm wrong). |
Not that I know but it might be. AFAIK there is only one log level configured in the config ini. |
I think it's changed in DI in the Monolog plugin ( |
We already log some information in debug level. However, it is not practical in Matomo to lower the debug level because then those messages would be sent to the user.
It would be useful to have a config like
archiving_profile_cli=0/1
or two configs likearchiving_profile = 0/1
andarchiving_profile_mode[]='cli' / 'web'
.The output of this should be visible in the cli archive log if easily possible otherwise only in logs.
We should log info:
Plugin Archiving: plugin: $PluginName, period: $period, segment: $segmentStringIfSet, siteId: $site, Duration $duration, Memory Peak: $memoryPeak
We don't need summary per query for now. It is only for an indication to see how long archiving takes in various places.
The text was updated successfully, but these errors were encountered: