Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new method to detect if root request is an API request #12913

Merged
merged 3 commits into from May 15, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented May 14, 2018

See changes.

@tsteur tsteur added the Needs Review PRs that need a code review label May 14, 2018
@tsteur tsteur added this to the 3.5.1 milestone May 14, 2018
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the comment, LGTM

@@ -14,6 +14,8 @@
</p>
</div>

{{ postEvent('Template.afterGDPROverviewIntro') }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be in this PR? Seems unrelated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep it was supposed to be, forgot to mention it... didn't want to create a new PR for it :)

@tsteur tsteur merged commit 8caf152 into 3.x-dev May 15, 2018
@tsteur tsteur deleted the apirootrequest branch May 15, 2018 20:09
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
…g#12913)

* Add new method to detect if root request is an API request

* Update CHANGELOG.md

* add docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants