Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent possible fatal when showing deleted goals in visitor profile #12910

Merged
merged 1 commit into from May 17, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 14, 2018

fatal was Error: {"message":"Key "6" does not exist as the array is empty.","file":"/plugins/Live/templates/_profileSummary.twig","line":24}

@sgiehl sgiehl added Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review labels May 14, 2018
@sgiehl sgiehl added this to the 3.5.1 milestone May 14, 2018
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't reproduce the fatal, but lgtm

@diosmosis diosmosis merged commit 4397892 into 3.x-dev May 17, 2018
@diosmosis diosmosis deleted the removedgoal branch May 17, 2018 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants