Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworking FixDuplicateActions queries #12896

Closed
wants to merge 1 commit into from
Closed

Reworking FixDuplicateActions queries #12896

wants to merge 1 commit into from

Conversation

software-opal
Copy link

This should speed up the fixing process.

It may also fix #12185; but I'll need to check against my database without extra indexes.

This should speed up the fixing process.
@sgiehl sgiehl added the Needs Review PRs that need a code review label May 12, 2018
@software-opal
Copy link
Author

So ... running this on my test box made the whole thing run slower ... which is probably the opposite of what we wanted.

In my eyes, the problem boils down to the database server needing to perform a full table scan for every single query; and with a large table(mine is upwards of 225 million) this is mind-numbingly slow.

I'd suggest adding a few indexes to the impacted columns, but this would come at the expense of the extra storage for those indexes; and the setup time for them too.

@mattab
Copy link
Member

mattab commented Jun 26, 2018

Hi @leesdolphin
Thanks for creating the PR 👍
As you mention that it is slower to run the many queries instead of the big one, we won't review further this PR. we'll need to find another solution for #12185

@mattab mattab closed this Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core:fix-duplicate-log-actions would take 2.5 years
3 participants