Check configured variables for availability in GeoIP2 server module #12892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
Enhancement
|
UI test failures seem unrelated, but not sure why it fails w/ |
|
Ok, found out why the UI tests fail: Looks like the Think a quick fix would be to just disable the command if |
sgiehl
force-pushed
the
geoip2servermodule
branch
2 times, most recently
from
fa17743
to
b5a5d89
Compare
diosmosis
reviewed
May 20, 2018
| foreach ($systemSettings->geoIp2variables as $name => $setting) { | ||
| $settingValues[$name] = $setting->getValue(); | ||
| } | ||
| } catch (\Exception $e) { | ||
| } | ||
|
|
||
| $cache->save($cacheKey, $settingValues); |
There was a problem hiding this comment.
Is it ok to save these values in the cache if getting the system settings fails?
There was a problem hiding this comment.
that should only occur in tests. But guess it's better not to cache on failure
sgiehl
force-pushed
the
geoip2servermodule
branch
from
b5a5d89
to
1a2cc63
Compare
diosmosis
force-pushed
the
geoip2servermodule
branch
from
1a2cc63
to
d3e1664
Compare
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…atomo-org#12892) * Check configured variables for availability in GeoIP2 server module * Update system test expected files. * catch exception for tests * do not cache on failure * Update expected admin screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it's difficult to enable the module on nginx, as
MMDB_ADDRorMMDB_INFOvariables needs to be defined, which isn't the case.See https://forum.matomo.org/t/geoip2-system-check-like/28251