@sgiehl opened this Pull Request on May 9th 2018 Member

fixes #12871

@diosmosis commented on May 18th 2018 Member

Unrelated to this PR, but noticed in https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/GeoIp2/GeoIp2.php#L26, we're checking if the current location provider is an instance of the GeoIp2 plugin. I think the full namepsace needs to be there. Missed this in last PR review.

@diosmosis commented on May 18th 2018 Member

Tested locally, works, just need to fix the tests.

@sgiehl commented on May 18th 2018 Member

@diosmosis fixed the check and updated the tests.

This Pull Request was closed on May 20th 2018
Powered by GitHub Issue Mirror