Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5.0] archive_tar must updated to 1.4.3 #12868

Closed
tuxmaster opened this issue May 9, 2018 · 5 comments · Fixed by #12872
Closed

[3.5.0] archive_tar must updated to 1.4.3 #12868

tuxmaster opened this issue May 9, 2018 · 5 comments · Fixed by #12872

Comments

@tuxmaster
Copy link

Hello the last matomo comes with archive_tar 1.4.2, but this version fails with php 7.2
For example the download of the geoip2 data bases fails with:

PHP Fatal error: Cannot use result of built-in function in write context in /var/www/piwik/html/vendor/pear/archive_tar/Archive/Tar.php on line 662

This bug is also noted on the pear site

@fdellwing
Copy link
Contributor

Please note that PHP7.2 is still not officially supported. This should be fixed nonetheless.

@Findus23
Copy link
Member

Findus23 commented May 9, 2018

Oddly I am using PHP 7.2 and didn't have the issue.

@DvdGiessen
Copy link

@fdellwing What is the correct supported range of PHP version for the latest version (3.5.0 as of writing) of Matomo? As per the documentation and the README distributed with the latest version the required PHP version is "5.5.9 or greater".

Might it perhaps be a good idea to document up till which version of dependencies Matomo was tested to work correctly for a given release? That would also ensure that the required versions are clear in the future.

If hypothetically the PHP team would release a version 8 which breaks Matomo in every way imaginable, right now we'd have to update documentation to explicitly state it is not supported. Even then, we cannot update the README files included in previous releases. If we denote the last version that Matomo was tested against, users at least have a reference as to what is supposed to work and what is something to try at their own risk.

@futureweb
Copy link
Contributor

alright - until Matomo is updated to archive_tar 1.4.3 --> quick and dirty fix ...

pear/Archive_Tar@772f7d0

@fdellwing
Copy link
Contributor

Might it perhaps be a good idea to document up till which version of dependencies Matomo was tested to work correctly for a given release? That would also ensure that the required versions are clear in the future.

As far as I'm aware of travis runs with PHP5.6 but PHP7.0 is recommended. That is not optimal, but it means that >PHP7.0 is tested even less. So specifing this should be a good idea. @mattab

futureweb added a commit to futureweb/matomo that referenced this issue May 9, 2018
sgiehl pushed a commit that referenced this issue May 9, 2018
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this issue Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants