Prevent possible view access error #12854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix #12842 I would assume this change fixes the issue. In theory it should still work even without this change and it usually does (cause it would use the first siteId within the list). It would be interesting to see what the `site` and `access` table on this instance looks like. Update: I can think of an error when idSite 1 was deleted see https://3v4l.org/gEvUb So this change likely fixes it.
|
@tsteur Totally forgot this issue until I just noticed that the GDPR tool works fine on my instance. (So this should have fixed the issue.) And indeed I seem to have deleted the |
mattab
added
the
not-in-changelog
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
fix matomo-org#12842 I would assume this change fixes the issue. In theory it should still work even without this change and it usually does (cause it would use the first siteId within the list). It would be interesting to see what the `site` and `access` table on this instance looks like. Update: I can think of an error when idSite 1 was deleted see https://3v4l.org/gEvUb So this change likely fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12842
I would assume this change fixes the issue. In theory it should still work even without this change and it usually does (cause it would use the first siteId within the list). It would be interesting to see what the
siteandaccesstable on this instance looks like.Update: I can think of an error when idSite 1 was deleted see https://3v4l.org/gEvUb
So this change likely fixes it.