@tsteur opened this Pull Request on May 5th 2018 Member

Otherwise it shows a json encoded array as default value.
image

Especially in combination with the new form field multi tuple added in https://github.com/matomo-org/matomo/pull/12807

@sgiehl commented on May 15th 2018 Member

Maybe we should adjust the Demo UI page to include default values. If I have seen that correctly there are currently none...

@tsteur commented on July 24th 2018 Member

@sgiehl is it ok to just merge for now and not show default value when default is an array/object which may be complex to show anyway?

@sgiehl commented on July 25th 2018 Member

For me the changes simply don't work as expected. Here's an example of an multituple field that still shows the default:

                <div piwik-field uicontrol="multituple" name="multitupletextvalue"
                     title="Multiple values with values"
                     default='[{"index": "test", "value":"myfoo"},{"index": "test 2", "value":"myfoo 2"}]'
                     value='[{"index": "test", "value":"myfoo"}]'
                     inline-help="Multi Tuple again."
                     ui-control-attributes='{"field1":{"key":"index","title":"Index","uiControl":"text","availableValues":null},"field2":{"key":"value","title":"Value","uiControl":"text","availableValues":null}}'>
                </div>
@tsteur commented on August 2nd 2018 Member

@sgiehl can you check again?

This Pull Request was closed on August 2nd 2018
Powered by GitHub Issue Mirror