@diosmosis opened this Pull Request on May 5th 2018 Member

Note: this PR has API changes.

image

This PR makes two changes to the way notifications are handled/displayed:

  • Transient notifications are now removed when the reporting page changes.
  • ViewDataTables have a view property called 'notifications' which can be used to add new notifications when loading a report. This is not in the Config so is not API. (The actual creation of notifications is done in the widget loader directive.)

Individual changes:

  • Remove 'notification_parser.js' and replace w/ notification.service.js angular service.
  • Add 'notifications' property to ViewDataTable's View & handle in _dataTable.twig. The widget loader directive initiates the "parse" of the divs outputted in _dataTable.twig. (Also done by widget loading logic in dashboard code.)
  • In reporting page controller, clear transient notifications after page load.
  • Added getSegmentByDefinition() function to SegmentEditor Model.
  • Add new event Visualization.onLoadingError that is triggered when there an exception is caught when loading report data.
  • Add new event Archive.noArchivedData that is triggered when during an API request no archive data can be found.
  • Use new event to display a notification when a report has no data and is for an unprocessed segment.

Fixes #12256
Fixes #12255

@diosmosis commented on May 6th 2018 Member

Adding to 3.5.0 milestone in case it can go in, if not can remove it.

@diosmosis commented on May 21st 2018 Member

@tsteur would you have time to review this PR?

Powered by GitHub Issue Mirror