Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing missing Google indexed pages and Domain age information in SEO Rankings widget #12821

Merged
merged 2 commits into from May 5, 2018

Conversation

genseirin
Copy link
Contributor

  1. "Google indexed pages" was empty: fetchIndexedPagesCount() in Google class didn't manage to retrieve the page because of a redirect (302 Moved) to https://.
  2. Domain age was sometimes empty when https://www.whois.com/whois/ was queried. Need to search for string "Registration Date:".

@sgiehl
Copy link
Member

sgiehl commented May 5, 2018

Thanks for the PR 👍

@sgiehl sgiehl added this to the 3.5.0 milestone May 5, 2018
@sgiehl sgiehl added the Bug For errors / faults / flaws / inconsistencies etc. label May 5, 2018
@sgiehl sgiehl merged commit 42ad8ad into matomo-org:3.x-dev May 5, 2018
@mattab mattab changed the title Fixing some missing information in SEO Rankings widget Fixing missing Google indexed pages and Domain age information in SEO Rankings widget May 8, 2018
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
)

* https://www.whois.com/whois/ uses identifier "Registration Date:"

* Using http:// returns "302 Moved" with link to https://
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants