New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate DB-Ip support by default for all users #12811
Comments
With #15521 geoip legacy support will be removed and the db update will be done with Matomo 4. |
@mattab given dbip's city inaccuracies, should this still be done? |
Ideally we would present both options, the pros and cons:
people in one click can setup the DB-IP if they choose to, or instead register to GeoIp and then enter the info in the UI so Matomo will automatically download their DB using their credentials. Thoughts? |
@mattab this functionality is already available in the geolocation admin page, what would you change? |
The goal of this issue should be
|
Will also need to ensure it's just the free version that has issues. |
Matomo 4 doesn't support the old GeoIP Legacy format any longer since #15521. The update currently switches users that were using an old database to the default provider. So that might need to be changed to an automatic switch to DB-IP database. |
Should we really do that without any bigger notice or possibility to not do that? |
I would not automatically set up GeoIP, but adding a new setup page sounds like a good idea so people are not confused (e.g. https://forum.matomo.org/t/matomo-and-geolocation-getting-the-location-wrong-from-my-linux-machine/36934) |
Not sure what the problem be with automatically installing DB-IP in the background? It be a better default than detecting country based on language and realistically > 80% will want to set this up anyway. |
@tsteur I have no problem with offering an automatic setup. But I don't think it's good not to give the user the opportunity to opt out. Some people might not want to have a geolocation at all because of privacy reasons. For others it might possibly be a no go that installing Matomo triggers an automatic download of a ~80MB file. Others might have already a set up server module, where downloading DB-IP is simply unneeded. |
I think automatically loading any files after install seems really suspicious. Also people expect that the matomo.zip and the So if we would make it automatically, we would have to include the db in the original matomo.zip (but that would create new issues) |
We could generally also add it to the LEGALNOTICE? On WP it's fine to do this as long as you mention it in the readme (the plugin directory page). If it's easy to do we can also add a checkbox to the installer (maybe enabled by default since it would be in the interest of most users to have this enabled) and it could mention it will download the DB and have a link to the license maybe or so. Could also mention ( Otherwise we'd need to disable all geolocation plugins (User Country etc) by default as we can't have the country detected by the language anymore.
There will be for sure a few users, but it's also easy to disable/change it later if someone really wants to use eg a server module. We shouldn't make a bad decision for say 95% of the users just because a few users wouldn't want it. So adding a checkbox in the installer should be fine, it would be enabled by default. |
Sounds fine for me. While thinking about where we could add it, I was wondering if it maybe would make sense to add a complete new step in installation for "Privacy". There we could also directly make it possible to set some basic privacy setting like ip anonymization |
Now that we have Geoip2 activated by default for all new users (done in #12699), we should also activate the feature for all existing users who are upgrading. Since Geoip2 requires a DB update for the Region column, we need to wait for Matomo 4 to enable the plugin.
Suggested steps for final Geoip2 takeover
The text was updated successfully, but these errors were encountered: