Automatically initialize title tooltips after loading a report #12800
Conversation
sgiehl
added
not-in-changelog
There was a problem hiding this comment.
Appears to work, tested tooltips in datatable, visitorlog, etc., existing tooltips work, and other places have tooltips now. Left one minor comment.
Actually, one possible idea, though not sure how good it is. An alternative solution might be to make the title= attribute an angular directive that uses $(element).tooltip(). This might be better than calling it on a root element, which I believe would have to select each sub element w/ a title? Nah, that's probably not really better. I think the solution in the PR is good 👍
| }, | ||
| show: false, | ||
| hide: false | ||
| }); |
There was a problem hiding this comment.
Should we also destroy the tooltip when the scope is destroyed?
There was a problem hiding this comment.
Guess it doesn't hurt to do so. Will add it...
|
There's a UI test failing: https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/27273/UIIntegrationTest_segmented_visitorlog.png looks like the row in visitor logs shouldn't have a tooltip? |
|
That's caused by the way the ui test is done. It triggers a direct click on the icon without moving the mouse. The tooltips seems to come from the datatable that opens the segmented visitor log. |
|
Tests work again... |
…o-org#12800) * Automatically initialize title tooltips after loading a report * destroy tooltips upon scope destroy * avoid tooltip
not sure if there would be a better place to handle that, but at least it seems to work this way ;-)
fixes #12676