@sgiehl opened this Pull Request on April 30th 2018 Member

fixes #12627

@diosmosis commented on April 30th 2018 Member

LGTM. Do you think it would be worthwhile to mention this change in the changelog? That plugins that add overridable array ViewDataTable properties can now accept comma separated lists from query parameters? Although I originally remember this being supported by columns_to_display, so maybe it's more of a regression.

@sgiehl commented on April 30th 2018 Member

columns could be given as comma separated list. Not sure if that applied for columns_to_display as well. I'm not sure if we should mention it in the changelog... @mattab any opinion?

@diosmosis commented on April 30th 2018 Member

Right, maybe I'm thinking about columns

@mattab commented on May 2nd 2018 Member

I reckon it's not needed to mention it in this case

This Pull Request was closed on May 2nd 2018
Powered by GitHub Issue Mirror