New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not show 'all' limit selector option for VisitorLog & default to 25 if filter_limit=-1 used #12790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a minor feedback
if (!is_numeric($this->requestConfig->filter_limit) | ||
|| $this->requestConfig->filter_limit == -1 // 'all' is not supported for this visualization | ||
) { | ||
$this->requestConfig->filter_limit = 25; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here let's use General.datatable_default_limit
tiny feedback: Maybe you should avoid branches containing |
Oh whoops, didn't realize that would happen to the UI test viewer. I'll create a new branch to view tests results from |
…n visitorlog visualization.
… 25 (which is in the datatable_row_limits default config value).
…imit used in VisitorLog visualization.
e13b0a1
to
235bc53
Compare
Created branch to view build here: https://travis-ci.org/matomo-org/matomo/builds/373122394 |
Some UI test failures, should be fixed on merge since they will likely conflict w/ other PRs. |
@mattab can you approve if this is good to go now? will update the UI tests & merge at that point |
…5 if filter_limit=-1 used (matomo-org#12790) * Add disable_all_rows_filter_limit viewdatatable config option & use in visitorlog visualization. * If -1 filter_limit is used w/ visitor log visualization, change it to 25 (which is in the datatable_row_limits default config value). * Use datatable_default_limit as limit to set when unsupported filter_limit used in VisitorLog visualization. * Update screenshots.
Changes:
disable_all_rows_filter_limit
visualization property that can be used to disable the 'all' option from the limit selector.Fixes #12789