Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visitor log: do not allow to show "all" rows as it can time out #12789

Closed
mattab opened this issue Apr 29, 2018 · 2 comments
Closed

Visitor log: do not allow to show "all" rows as it can time out #12789

mattab opened this issue Apr 29, 2018 · 2 comments
Assignees
Labels
c: Performance For when we could improve the performance / speed of Matomo.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Apr 29, 2018

In Visitor Log, Ecommerce log, Media log, etc. it is currently possible to select all in the Rows selector, meaning that all visits will be displayed in the log.

The idea was to allow users to export "All" the visitor log data for a day. But since Matomo 3.4.0, a new export feature in #11958 is available, which lets user select the number of rows to export.

Therefore, it is not needed anymore to offer "All" in the rows selector for the purpose of exporting all data.

The problem

For many websites, selecting "All" will actually cause Matomo to time out with the following error:

Error: {"type":1,"message":"Maximum execution time of 240 seconds Exceeded", 
"file":"core\/EventDispatcher.php","line":105}
at index.php?forceView=1&viewDataTable=VisitorLog&module=Live&action=getLastVisitsDetails&small=1&idSite=21&period=day&date=2018-04-24&showtitle=1&random=2790

Suggested steps

  • Remove all from the rows selector from the Visitor Log, Ecommerce log, Media log, etc.
  • In the update, also delete all users' viewdatatable visualisations settings for Visitor log(s) where the setting includes "showing all rows". This way, any user who has already selected "All" will be reset to showing 25 rows or so by default.

As a result, we would expect a lot less timeouts triggered in Matomo.

@mattab mattab added the c: Performance For when we could improve the performance / speed of Matomo. label Apr 29, 2018
@mattab mattab added this to the 3.5.0 milestone Apr 29, 2018
@diosmosis diosmosis self-assigned this Apr 29, 2018
@diosmosis
Copy link
Member

@mattab is there still a showing all rows in non-visitor log like reports? Eg, normal table reports, actions reports.

@mattab
Copy link
Member Author

mattab commented Apr 30, 2018

So far the problem was always with the Visitor Log (as all other reports are in theory truncated after 500 or 1000 rows by default). So let's only change it to the Visitor log(s) for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Performance For when we could improve the performance / speed of Matomo.
Projects
None yet
Development

No branches or pull requests

2 participants