Prevent tracking failures when invalid goal patterns are defined #12787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested, works, think we should surround the logging call w/ a try/catch, though, just in case logging fails (if it's misconfigured, or there's some system problem). |
|
ok. I'll change it |
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…omo-org#12787) * Log warning instead of throwing an exception * add try/catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an invalid goal pattern type is defined in database, and exception might be thrown while tracking.
As an exception does not make sense at this point at all it now will log a warning instead of throwing an exception.
This will not prevent anyone from storing invalid patterns in the database, but will prevent tracking failures for already stored invalid data.
refs #12683