Do not assert on sort order of equal elements #12778
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three tests in
Piwik\Tests\Unit\DataAccess\JoinGeneratorTest
fail on PHP 7.PHP 7 contained a change to
uasort()
and friends that may result in different sorting of values that compare as equal.The three tests all sort three tables where the two of them do not depend on each other and may thus be returned in order. Hence we should not make assertions on their relative order.