Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a higher precision for rates to show more accurate percentage values #12775

Merged
merged 1 commit into from Apr 30, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Apr 27, 2018

Currently, we round to two decimals. This means when calculating the percentage (x 100) we show eg only 1% or 5% in custom reports. However, for conversion rates etc we should show more accurate values and therefore need to use a higher precision.

Currently, we round to two decimals. This means when calculating the percentage (`x 100`) we show eg only 1% or 5% in custom reports. However, for conversion rates etc we should show more accurate values and therefore need to use a higher precision.
@tsteur tsteur added the Needs Review PRs that need a code review label Apr 27, 2018
@tsteur tsteur added this to the 3.5.0 milestone Apr 27, 2018
@diosmosis diosmosis merged commit 38c9a6d into 3.x-dev Apr 30, 2018
@diosmosis diosmosis deleted the precisionrates branch April 30, 2018 23:56
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
…ues (matomo-org#12775)

Currently, we round to two decimals. This means when calculating the percentage (`x 100`) we show eg only 1% or 5% in custom reports. However, for conversion rates etc we should show more accurate values and therefore need to use a higher precision.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants