Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid MySQL Version when using MariaDB #12772

Closed
Findus23 opened this issue Apr 26, 2018 · 7 comments
Closed

Invalid MySQL Version when using MariaDB #12772

Findus23 opened this issue Apr 26, 2018 · 7 comments
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
3.5.0

Comments

@Findus23
Copy link
Member

Guess I cheered too soon.
Since I update my Matomo server to the latest beta, I can't access the marketplace.
Whenever I try to open
https://matomo.example/index.php?module=Marketplace&action=overview&idSite=7&period=month&date=today&activated=&mode=admin&type=&show=
I get An error occurred: Invalid MySQL Version

I am using MariaDB on Debian Stable (Stretch)

➜  ~/tools/certbot git:(master) mysql --version
mysql  Ver 15.1 Distrib 10.1.26-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2

MariaDB [(none)]> SELECT @@version;
+--------------------------+
| @@version                |
+--------------------------+
| 10.1.26-MariaDB-0+deb9u1 |
+--------------------------+
1 row in set (0.00 sec)

I guess this has something to do with #12551 as I don't think something else has changed.

@diosmosis How did you test the version string detection?
@Findus23 Findus23 added this to the 3.5.0 milestone Apr 26, 2018
@Findus23 Findus23 added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Apr 26, 2018
@diosmosis
Copy link
Member

Tested with mariadb through docker. Docker compose is here: https://github.com/diosmosis/matomo-test-environments/blob/master/mariadb/docker-compose.yml

@Findus23
Copy link
Member Author

@diosmosis I guess the mariadb docker version doesn't have the odd debian-specific +deb9u1 suffix.

@diosmosis
Copy link
Member

Reproduced locally, error does not occur in matomo, but when fetching this URL: https://plugins.matomo.org/api/2.0/plugins?keywords=&purchase_type=&query=&sort=lastupdated&release_channel=latest_stable&prefer_stable=1&piwik=3.5.0-b2&php=7.1.15&mysql=10.2.14-MariaDB-10.2.14%2Bmaria%7Ejessie&num_users=2&num_websites=1
I suppose plugins.matomo.org cannot handle the mariadb version.

CC @tsteur

@Findus23
Copy link
Member Author

Findus23 commented Apr 26, 2018 •
edited

That explains why I can nowhere find a validator or the error message string.

Locally I am using

+-------------------+
| @@version         |
+-------------------+
| 10.1.29-MariaDB-6 |
+-------------------+

and it works, so it is really the suffix (and probably the +)

@tsteur
Copy link
Member

tsteur commented Apr 26, 2018 •
edited

That's probably because we are using semver version format to validate the version number. I'll try to remove the + part automatically on the Marketplace.

@tsteur
Copy link
Member

tsteur commented Apr 26, 2018

fixed

@tsteur tsteur closed this as completed Apr 26, 2018
@Findus23
Copy link
Member Author

Just tested it and it's working fine.
Many thanks Thomas!

@tohn tohn mentioned this issue May 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
3.5.0
Development

No branches or pull requests
3 participants
@diosmosis @tsteur @Findus23