Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster unit testing #12760

Closed
wants to merge 4 commits into from
Closed

Faster unit testing #12760

wants to merge 4 commits into from

Conversation

szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Apr 23, 2018 •
edited

The purpose of this Pr is to measure long-running unit tests.

phpunit-speedtrap needs phpunit 7

@sgiehl sgiehl added the c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. label Apr 23, 2018
@szepeviktor
Copy link
Contributor Author

szepeviktor commented Apr 23, 2018 •
edited

Ancient PHP version prevents using modern tools 😢

@Findus23
Copy link
Member

@szepeviktor Indeed, but as 5.6 is still supported by PHP and a lot of people are still using it, it probably won't change soon.

https://demo-anonymous.matomo.org/index.php?module=CoreHome&action=index&idSite=1&period=year&date=today#?idSite=1&period=year&date=today&category=General_Visitors&subcategory=CustomVariables_CustomVariables

@Findus23
Copy link
Member

@szepeviktor
BTW, the file you are editing gets automatically generated by this software project, so you might want to propose your changes there:

https://github.com/matomo-org/travis-scripts

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Apr 23, 2018 •
edited

Class 'PHPUnit_Framework_TestCase' not found

There must have been an APi change in phpunit.

I am not god at projects for the masses on shared hosting.
Sorry.

@szepeviktor szepeviktor deleted the phpunit-speedtrap branch April 23, 2018 09:45
@sgiehl
Copy link
Member

sgiehl commented Apr 23, 2018 •
edited

Class 'PHPUnit_Framework_TestCase' not found

phpunit uses namespaces instead of those class names in newer versions

@szepeviktor szepeviktor mentioned this pull request Apr 23, 2018
Closed
@szepeviktor
Copy link
Contributor Author

Trying out an ancient version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@szepeviktor @Findus23 @sgiehl