Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CACHEDIR.TAG tag file in tmp/ #12754

Closed
u1735067 opened this issue Apr 22, 2018 · 1 comment · Fixed by #13653
Closed

CACHEDIR.TAG tag file in tmp/ #12754

u1735067 opened this issue Apr 22, 2018 · 1 comment · Fixed by #13653
Labels
Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone

Comments

@u1735067
Copy link

Hi,

some softwares, like borg backup, understand the CACHEDIR.TAG file to avoid handling / backuping files in the directory containing this file, maybe Matomo could put one in tmp/ (or the subdirectories) by default?

cat <<EOF >> tmp/CACHEDIR.TAG
Signature: 8a477f597d28d172789f06886806bc55
# This file is a cache directory tag created by Matomo.
# For information about cache directory tags, see:
#	http://www.brynosaurus.com/cachedir/
EOF
@Findus23 Findus23 added the Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. label Oct 2, 2018
literalplus added a commit to literalplus/matomo that referenced this issue Oct 29, 2018
Note that this does not handle cases where users delete the whole tmp/
directory. However, it is to be expected that users depending on
that file would take care not to delete it.

Fixes matomo-org#12754
@mattab
Copy link
Member

mattab commented Nov 14, 2018

Hi @Alex131089
Thanks for the suggestion! Do you mind testing the PR #13653 and confirm if it works for you?

@mattab mattab added this to the 3.9.0 milestone Nov 14, 2018
diosmosis pushed a commit that referenced this issue Jan 22, 2019
Note that this does not handle cases where users delete the whole tmp/
directory. However, it is to be expected that users depending on
that file would take care not to delete it.

Fixes #12754
@mattab mattab modified the milestones: 3.9.0, 3.8.1 Jan 22, 2019
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants