Update Travis to no longer run duplicated plugin tests #12740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests now need only 32 instead of 49 minutes. |
tsteur
added
the
not-in-changelog
|
fyi @sgiehl @mattab @diosmosis merging this now. Let me know in case there is a problem with it and we can undo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the MySQLi tests time out because they run for like 50 minutes. With PDO they take only 27 minutes. This is because the configuration in matomo-org/travis-scripts#40 was buggy as we ran System tests, Integration tests and plugin tests. However, plugin tests are a subset of integration and system tests and we ran many tests duplicated. See https://github.com/matomo-org/matomo/blob/3.4.0/tests/PHPUnit/phpunit.xml.dist#L22-L49