@szepeviktor opened this Pull Request on April 15th 2018 Contributor

/vendor should not be cached!

@szepeviktor commented on April 15th 2018 Contributor

Tests need fixing, see for example #12726

Please merge.

@szepeviktor commented on April 15th 2018 Contributor

@tsteur Maybe this one too?

@szepeviktor commented on April 23rd 2018 Contributor

@Findus23 Any chance merging this?

@Findus23 commented on April 23rd 2018 Member

@szepeviktor Currently GDPR has highest priority, once that is finished we'll get back to other issues.

Do you have any numbers how much this speeds up the build? I'd expected travis to already cache the repository so only the install should be skipped with this change.

@szepeviktor commented on April 23rd 2018 Contributor

@Findus23 This caches composer packages.

@Findus23 commented on April 23rd 2018 Member

@szepeviktor Indeed. This shows that the install currently takes about 30s, so your change will speed it up by that amount (minus the time composer needs for updating), correct?

@szepeviktor commented on April 23rd 2018 Contributor

@Findus23 Yes, bit-by-bit

This Pull Request was closed on May 31st 2018
Powered by GitHub Issue Mirror