Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Archiver should not launch daily and weekly/monthly/yearly archiving at the same time #12718

Closed
tsteur opened this issue Apr 12, 2018 · 1 comment
Labels
c: Performance For when we could improve the performance / speed of Matomo.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented Apr 12, 2018

This may happen for segments when you for example launch two archivers via the CLI.

console climulti:request -q --superuser module=API&method=API.get&idSite=1&period=day&date=last52&format=php&segment=visitorType%3D%3Dnew&trigger=archivephp
console climulti:request -q --superuser module=API&method=API.get&idSite=1&period=week&date=last2&format=php&segment=visitorType%3D%3Dnew&trigger=archivephp

The problem is, that the weekly archive requires the daily archive and this could potentially result in missing data or in additional work as they weekly archive may archive the days as well.

In #12702 we have already added a command to check whether another CLI command is already running to not process twice at the same time the same archive. However, in this case it wouldn't work directly because the period, and the date is different.

So when archiving week, we would need to check for example if day/last52 is already running, before archiving month, we would need to check also additionally for week/last260 etc...

@tsteur tsteur added the c: Performance For when we could improve the performance / speed of Matomo. label Apr 12, 2018
@mattab mattab added this to the 3.5.0 milestone Apr 12, 2018
@mattab
Copy link
Member

mattab commented Apr 12, 2018

in theory should be fixed with #12719 but we'll wait and confirm it doesn't occur again

@mattab mattab closed this as completed Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Performance For when we could improve the performance / speed of Matomo.
Projects
None yet
Development

No branches or pull requests

2 participants