Use latest referrer spam blacklist #12714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My referrer log is full of spam, the domains are on the list but Matomo is using a version of the list from a year ago
robocoder
reviewed
Apr 12, 2018
| @@ -41,7 +41,7 @@ | |||
| "symfony/monolog-bridge": "~2.6.0", | |||
| "symfony/event-dispatcher": "~2.6.0", | |||
| "pear/pear_exception": "~1.0.0", | |||
| "matomo/referrer-spam-blacklist": "~1.0", | |||
There was a problem hiding this comment.
That's not the problem. See https://getcomposer.org/doc/articles/versions.md#tilde-version-range-
~1.0 is the same as '>=1.0 < 2.0.0`
The reason for the older version is because it is (was) pinned in composer.lock. This is resolved by d9eef2a.
There was a problem hiding this comment.
Okay, I'm not fluent with Composer, my bad. The list has domains which are problematic for me, it just hasn't been released since January, haven't noticed that before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My referrer log is full of spam, the domains are on the list but Matomo is using a version of the list from a year ago