Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new event to add stylesheets #12705

Merged
merged 2 commits into from Apr 23, 2018
Merged

Added new event to add stylesheets #12705

merged 2 commits into from Apr 23, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Apr 9, 2018

This is useful when a plugin wants to dynamically add stylesheets which are not located in a file. For example when these styles come from a system setting etc.

@tsteur tsteur added the Needs Review PRs that need a code review label Apr 9, 2018
@tsteur tsteur added this to the 3.4.1 milestone Apr 9, 2018
sgiehl
sgiehl approved these changes Apr 21, 2018
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattab mattab merged commit f56a26f into 3.x-dev Apr 23, 2018
@sgiehl sgiehl deleted the stylesheetaddevent branch April 23, 2018 07:51
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@tsteur @InfinityVoid
added new event to add stylesheets (matomo-org#12705)
48fdd21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tsteur @sgiehl @mattab