Fix pageview metric so it doesn't include events #12700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
added
Bug
diosmosis
reviewed
Apr 9, 2018
|
|
||
| public function configureSegments() | ||
| { | ||
| } |
There was a problem hiding this comment.
Is this method needed? Think it can be removed unless we want to disable the use of segmentName for any derived classes.
There was a problem hiding this comment.
FYI, can fix myself if not needed.
There was a problem hiding this comment.
it is to not define segments for this again. otherwise will be auto generated
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
* remove pageviews dimension * add pageview metric again * Add quick comment to LinkVisitActionIdPages::configureSegments().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description:
At start, we're seeing as expected: 2 pageviews, 2 total events, 2 visits.
Click on the "Favourites" button which triggers an event. then I see: 3 pageviews, 3 total events, 2 visits --> Should only be 2 pageviews, not 3.