Add Piwik\Intl\Idn and TLD domain provider #12689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @robocoder Thanks for the PR. Is there by any chance an existing PHP package we could reuse for this logic? Maybe in the symfony codebase or so? |
|
Sorry, I don't have the interest/time to integrate 3rd party libs. If anyone is interested, look at https://github.com/arubacao/tld-checker (for the TLD list) and https://github.com/true/php-punycode (to encode/decode PunyCode). I recommend adding a wrapper to use the intl extension functions if available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean port of LGPL libidn2 punycode decoder.
Intended to be a starting point for #11640 (URL's with IDN shows in Punycode).
Unlike the punycode decoder in libs/Zend/Validate/Hostname.php, this decoder:
xn--e1afmkfd.xn--p1ai(see INTL_IDNA_VARIANT_UTS46)Might eventually allow removal of libs/Zend/Validate (if someone writes an email address validator). The code point validator in Zend_Validate_Hostname is dubious given the preg_match buffer limit.