Not sure if the comment might be incorrect in this case. Removing those values for all users might have other results than expected. Without the visitorId / userid features like the visitorprofile might not work...

In my case, I was doing something like this:

Piwik::doAsSuperUser(function () {
  return \Piwik\API\Request::processRequest('Live.getLastVisitsDetails'

and these values were removed, which surprised me since I used doAsSuperUser.

Hi @letharion
Thanks for the PR. In this case as per @sgiehl comment, we couldn't make the change. Maybe instead we should fix the functions doAsSuperUser/ isUserIsAnonymous so they work as expected together?

@mattab Thank you for your comment. I've made another attempt here: #12766 Is this the sort of check you meant?

I could update the comment instead then, in case it's incorrect, if that's desirable?

@sgiehl You said Removing those values for all users but that appears to be a misunderstanding. I'm not removing the values for anyone, I'm making sure they remain when the user has super access.

@letharion Yes I meant this 👍 #12766