Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goals may be created with invalid metadata causing tracking to fail #12683

Closed
mattab opened this issue Mar 29, 2018 · 3 comments
Closed

Goals may be created with invalid metadata causing tracking to fail #12683

mattab opened this issue Mar 29, 2018 · 3 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Mar 29, 2018

Seen in production

In at least one case we have noticed that some Goals were found to be invalid in the database:

image

This unfortunately seemed to cause tracking to fail for at least some of the requests: Error in Matomo (tracker): General_ExceptionInvalidGoalPattern

Steps:

  • we should check that Goals attributes values are checked and how this could have happened and how can it be prevented.
  • ideally the tracker should not fail when a goal is invalid, not because these checks are removed, but because the goal is fully checked and validated at every creation/update
@mattab mattab added the Bug For errors / faults / flaws / inconsistencies etc. label Mar 29, 2018
@mattab mattab added this to the 3.4.1 milestone Mar 29, 2018
@sgiehl
Copy link
Member

sgiehl commented Mar 30, 2018

Are you sure those goals might not have been created using the API directly?

@tsteur
Copy link
Member

tsteur commented Mar 30, 2018

The API should make sure no invalid values can be assigned.

@mattab
Copy link
Member Author

mattab commented May 4, 2018

In theory it's fixed (?) so closing it

@mattab mattab closed this as completed May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

3 participants