Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iframe opt-in/opt-out code is not properly closed #12665

Closed
dev-101 opened this issue Mar 28, 2018 · 1 comment · Fixed by #12668
Closed

iframe opt-in/opt-out code is not properly closed #12665

dev-101 opened this issue Mar 28, 2018 · 1 comment · Fixed by #12668
Assignees
Milestone

Comments

@dev-101
Copy link

dev-101 commented Mar 28, 2018

Hi, after updating to 3.4.0 and checking HTML opt-in/opt-out code, the generated code looks like this:

<iframe style="border: 0; height: 200px; width: 600px;" src="https: // ... /index.php?module=CoreAdminHome&action=optOut&language=en&backgroundColor=&fontColor=&fontSize=&fontFamily=" >

However, this breaks my page completely, everything below the embedded code above ends-up hidden inside the iframe. This is because the code itself for iframe is not properly closed:

<iframe style="border: 0; height: 200px; width: 600px;" src="https: // ... /index.php?module=CoreAdminHome&action=optOut&language=en&backgroundColor=&fontColor=&fontSize=&fontFamily=" ></iframe>

Not sure if this is because I updated Matomo, maybe it does not happen in fresh installations. However, check if you missed the closing </iframe> tag in your HTML template.

Thanks!

@sgiehl sgiehl added this to the 3.4.1 milestone Mar 28, 2018
@sgiehl
Copy link
Member

sgiehl commented Mar 28, 2018

Thanks for the report. Seems the closing tag got lost...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants