Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the Visitors in Real time widget, do not write "Keyword not defined" #12655

Closed
mattab opened this issue Mar 27, 2018 · 4 comments · Fixed by #12659
Closed

In the Visitors in Real time widget, do not write "Keyword not defined" #12655

mattab opened this issue Mar 27, 2018 · 4 comments · Fixed by #12659
Assignees
@sgiehl
Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
3.5.0

Comments

@mattab
Copy link
Member

mattab commented Mar 27, 2018

Similarly to how it looks in the Visitor Log, let's hide the keyword when it is not know, ie. let's hide Keyword not defined in the "Visitors in Real time" widget.
@mattab mattab added the c: Usability For issues that let users achieve a defined goal more effectively or efficiently. label Mar 27, 2018
@mattab mattab added this to the 3.4.1 milestone Mar 27, 2018
@sgiehl sgiehl self-assigned this Mar 27, 2018
@sgiehl sgiehl mentioned this issue Mar 27, 2018
Merged
@mattab
Copy link
Member Author

mattab commented Apr 23, 2018

Also, @sgiehl let's hide the Keyword not defined in the Tooltip in the visitor log on hover on the search engine icon as it's creating some confusion too.

@sgiehl
Copy link
Member

sgiehl commented Apr 25, 2018

I'll include that in the referenced PR

@mattab
Copy link
Member Author

mattab commented Apr 30, 2018

@sgiehl can you confirm you removed the "Keyword not defined" tooltip in the Visitor Profile as well as Visitor log? ie. everywhere where it could be shown?

@sgiehl
Copy link
Member

sgiehl commented Apr 30, 2018

Yes. My referenced PR changes the code so Realtime log, visitor log and visitor profile now uses the same code without that tooltip.
Btw. I've just create a PR for visitor generator plugin, so it also generates some visits with search engine referrers without keywords, so stuff like this is easier to test ;-)

@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
c: Usability For issues that let users achieve a defined goal more effectively or efficiently. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
3.5.0
Development

Successfully merging a pull request may close this issue.

Improve realtime visitor log widget matomo-org/matomo
2 participants
@mattab @sgiehl