Recreating "Use flex for sparkline text instead of block" by @fdellwing #12633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks guys for letting this happen. This was quite a hard job for a non web-developer and I'm happy it turned out fine. |
|
@fdellwing if you can use flexbox, you're already ahead of many web developers ;) |
mattab
added
the
not-in-changelog
mattab
changed the title
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…block" - @fdellwing (matomo-org#12633) * repush matomo-org#12466 * dont allow the sparkline to shrink * remove unneeded css * Add -ms-flex to sparkline trigger correct display in IE10. * update screenshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-creating #12628 after rebase + UI test fix. For some reason Dashboard_reset.png never updates in LFS.
Fixes #12628