Makes report generation site aware #12626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t dimensions based on the current site.
…elper method in CacheId.
…et values if they were not set to begin w/ + add test for CacheId::overwriteIdSiteForCache().
sgiehl
commented
Mar 18, 2018
| @@ -117,7 +117,7 @@ private static function getMapOfModuleActionsToReport() | |||
| public function getAllReports() | |||
| { | |||
| $reports = $this->getAllReportClasses(); | |||
| $cacheId = CacheId::languageAware('Reports' . md5(implode('', $reports))); | |||
| $cacheId = CacheId::siteAware(CacheId::languageAware('Reports' . md5(implode('', $reports)))); | |||
There was a problem hiding this comment.
The method itself does not really need an site aware caching, but the event Report.addReports might add reports based on the site id. Which is actually the case in some of our plugins...
|
Haven't tested it but code looks straight forward. (compare here: site-aware-dimensions-cache...archivetasks ) |
|
LGTM, this can probably be merged w/o #12618, would make it easier |
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
* Make dimensions cache site aware since CustomDimensions adds different dimensions based on the current site. * Unset idSites when overwriting idSite for cache & move that code to helper method in CacheId. * Handle idsite tracker param in CacheId::siteAware(). * Handle both $_GET and $_POST members in CacheId::siteAware(). * Use CacheId::siteAware() in MetricsList. * Set idsite if in tracker mode when overwriting idSite for cache + unset values if they were not set to begin w/ + add test for CacheId::overwriteIdSiteForCache(). * Fix tests: return idArchive in ArchiveProcessor\Loader::prepareArchvie(). * Move CacheId idSite overwriting function to Context class. * Support $_GET/$_POST values being arrays in CacheId::siteAware to fix test. * switch site context when generating reports * makes ReportsProvider site aware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #12618
fixes #12560