Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer documentation: the list of all segments is missing the "Metrics" segments #12590

Closed
mattab opened this issue Mar 5, 2018 · 4 comments
Assignees
Milestone

Comments

@mattab
Copy link
Member

mattab commented Mar 5, 2018

Just noticed a regression in : https://developer.matomo.org/api-reference/reporting-api-segmentation

Below the title "Metrics" it should list all metric segments. But there is nothing displayed after the Metrics title.

See the original API response here: https://demo2.matomo.org/index.php?module=API&action=listSegments&language=en

@mattab mattab added this to the 3.3.1 milestone Mar 5, 2018
@sgiehl
Copy link
Member

sgiehl commented Mar 9, 2018

There are no metrics left to display, as all segments are dimensions or are changed to dimension after https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/API/Controller.php#L83-L85
Maybe that additional check is outdated as it converts all metric segments to dimensions?

@diosmosis diosmosis self-assigned this Mar 19, 2018
@diosmosis
Copy link
Member

diosmosis commented Mar 19, 2018

@mattab looked further into @sgiehl's insight and saw that the if in question is regarding the "event value" segment, and noticed this segment was removed in 641e9ce . If it's not supposed to be a segment, we can remove that check to show those segments in the "Metrics" category.

@mattab
Copy link
Member Author

mattab commented Mar 20, 2018

@diosmosis segment value should be a new segment ideally, as it would be useful for some use cases.

@diosmosis
Copy link
Member

@mattab so add a "event value" segment? and it would be a "dimension" metric, correct? I'll try to add it & then will remove the if block that's causing metric segments to be displayed as dimension segments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants