Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Dashboard API methods: copyDashboardToUser, createNewDashboardForUser, removeDashboard and resetDashboardLayout #12587

Merged
merged 3 commits into from Mar 9, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 27, 2018

No description provided.

@sgiehl sgiehl added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Feb 27, 2018
@sgiehl sgiehl force-pushed the dashboardapi branch 2 times, most recently from 5fae722 to 235ddd6 Compare February 28, 2018 19:16
@sgiehl sgiehl added Needs Review PRs that need a code review c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Feb 28, 2018
@mattab mattab added this to the 3.3.1 milestone Mar 9, 2018
@diosmosis
Copy link
Member

LGTM, merged w/ 3.x-dev & tweaked APITest since I noticed it was using the wrong parameter for a one API call.

@mattab mattab merged commit b77050f into 3.x-dev Mar 9, 2018
@sgiehl sgiehl deleted the dashboardapi branch March 9, 2018 07:39
@mattab mattab added the Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. label Mar 27, 2018
@mattab mattab changed the title Moves some dashboard methods to API New Dashboard API methods: copyDashboardToUser, createNewDashboardForUser, removeDashboard and resetDashboardLayout Mar 27, 2018
@mattab mattab added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. and removed Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. labels Mar 27, 2018
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
* Move some dashboard methods to API

* Pass correct param in dashboard APITest for createNewDashboardForUser API method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants