New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update list of valid TLDs and IDNs #12555
Conversation
robocoder
commented
Feb 12, 2018
- Backport changes from:
- Zend_Validate_Hostname from ZF 1.12.20
- Zend\Validator\Hostname ZF2 (b3ebdf2, Feb 1, 2018)
Maybe it would be better to replace Zend_Validate_Hostname with a custom validator and library, eg Piwik\Intl\DomainName? It could ship with a list of TLDs and IDNs but also have a way to download/use an out-of-band update. |
Hi @robocoder
Would you be able to update this integration test so it passes again? |
I'll look at it later this evening. |
The regex pattern buffer max length is determined by a compile-time setting when building php. Since this can vary between platforms, I arbitrarily used a cutoff of 256. |
Please remove the |