JS Tracker: expected no warning in the console when addTracker multiple times #12545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattab
added
Bug
tsteur
reviewed
Feb 9, 2018
js/piwik.js
Outdated
| @@ -7084,7 +7084,10 @@ if (typeof window.Piwik !== 'object') { | |||
| apply(paq[iterator]); | |||
| delete paq[iterator]; | |||
|
|
|||
| if (appliedMethods[methodName] > 1) { | |||
| var isMethodCallableMultipleTimes = ["addTracker"], | |||
| shouldMethodBeCalledOnceOnly = isMethodCallableMultipleTimes.indexOf(methodName) === -1; | |||
There was a problem hiding this comment.
you want to use indexOfArray as .indexOf is not available in all browsers.
Also be good to use to var statements. isMethodCallableMultipleTimes be better renamed to methodsCallableMultipleTimes as it is not a boolean.
In theory it would be even doable to just say methodName !='addTracker' as more is not needed right now.
sgiehl
approved these changes
Feb 10, 2018
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…le times (matomo-org#12545) * Simple banner * Fix bug * Keep it simple
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
addTrackeris called twice or more, currently the following message is displayed in the console:In reality it's allowed to call
addTrackermultiple times and this is an edge case as all other methods should only be called once:var applyFirst = ['addTracker', 'disableCookies', 'setTrackerUrl', 'setAPIUrl', 'enableCrossDomainLinking', 'setCrossDomainLinkingTimeout', 'setSecureCookie', 'setCookiePath', 'setCookieDomain', 'setDomains', 'setUserId', 'setSiteId', 'enableLinkTracking'];