Possibility to login by email #12543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsteur
reviewed
Feb 8, 2018
plugins/Login/Controller.php
Outdated
| @@ -118,6 +121,19 @@ function login($messageNoAccess = null, $infoMessage = false) | |||
| return $view->render(); | |||
| } | |||
|
|
|||
| protected function getLoginFromLoginOrEmail($loginOrEmail) | |||
There was a problem hiding this comment.
Be good to have this method ideally outside the controller or make it at least private so it can for sure not be executed?
There was a problem hiding this comment.
changed the method to private
|
Does "lost your password" work with email? Haven't tested. |
|
Tested successful logins / and failed logins: Works and no information is exposed on unsuccessful logins etc 👍 |
|
Password resetting already worked with email. See https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/Login/PasswordResetter.php#L161-L176 |
tsteur
approved these changes
Feb 8, 2018
mattab
added
the
not-in-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite simple solution for #11959.