Show city / country in visitor details #12534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
force-pushed
the
locationinlog
branch
3 times, most recently
from
2945e55
to
06501e4
Compare
sgiehl
force-pushed
the
locationinlog
branch
2 times, most recently
from
72d9b91
to
4fb48d7
Compare
|
I see two flags now, if that's ok, then LGTM |
mattab
requested changes
Mar 20, 2018
There was a problem hiding this comment.
Review
- Visitor log: Let's remove the flag in the middle column, and leave only the flag in the first column next to country/city name.
- Visitor profile: let's remove the flag in each visit on hover, and only show the flag in the top left profile, as well as when the visit is expanded to show detailed visit info.
- When the geolocation is Unknown, do not display the flag+text. For privacy reasons it may be more common in the future not to collect accurate geo location data and we can simply not show it then.
sgiehl
force-pushed
the
locationinlog
branch
2 times, most recently
from
7bf4aee
to
c5ce869
Compare
|
Updated the PR accordingly... UI files need an update before merging. |
|
@sgiehl Looks good 👍 can you update the UI tests/rebase and merge this? |
sgiehl
force-pushed
the
locationinlog
branch
2 times, most recently
from
9e22a7e
to
89151b9
Compare
|
@sgiehl Is it intentional that the flag is now only 16x12 instead of 20.66x16 as before? |
mattab
added
the
not-in-changelog
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
* Show city or country in visitor details * update UI files * Show country flag and location only if not unknown * hide flag icon in icon list * update UI files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12015