Add more date segments: visitEndServerDate visitEndServerDayOfMonth visitEndServerDayOfWeek visitEndServerDayOfYear, etc. #12521
Conversation
tsteur
added
Enhancement
| use Piwik\Columns\MetricsList; | ||
| use Piwik\Plugin\Dimension\VisitDimension; | ||
| use Piwik\Metrics\Formatter; | ||
| use function Piwik\Plugins\VisitTime\translateDayOfWeek; |
There was a problem hiding this comment.
use function is available in PHP 5.6+ only, but we still support 5.5.9+.
See https://secure.php.net/manual/en/language.namespaces.importing.php
There was a problem hiding this comment.
Thanks, fixed! Didn't notice it. Will have an eye on the tests once they are finished.
|
The only failing test now should be in CustomDimensions plugin a system test that we could fix when merged or so? |
| public function __construct() | ||
| { | ||
| $this->suggestedValuesCallback = function ($idSite, $maxValuesToReturn) { | ||
| return range(2016, min(2036, $maxValuesToReturn)); |
There was a problem hiding this comment.
I'm not sure if that's what it's meant to be. If $maxValuesToReturn is 30 like in the tests, it returns a range from 2016 down to 30. I guess it would be better to use something like return range(2016, 2016 + $maxValuesToReturn); ?
There was a problem hiding this comment.
Absolutely right, not sure what I was thinking... pushing a fix now.
| protected $columnName = 'visit_last_action_time'; | ||
| protected $type = self::TYPE_DATETIME; | ||
| protected $segmentName = 'visitEndServerDayOfWeek'; | ||
| protected $nameSingular = 'VisitTime_ColumnVisitEndServerWeek'; |
There was a problem hiding this comment.
Seems that translation key does not exists. Guess it needs to be VisitTime_ColumnVisitEndServerDayOfWeek
There was a problem hiding this comment.
Cheers... great find. Fixed it. Will have an eye on tests.
|
FYI: Seems like the tests for |
mattab
changed the title
Adds the following new date segments (and dimensions basically):
Tests will need to be fixed afterwards.