Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure test fixture symlinks are created correctly #12515

Merged
merged 1 commit into from Jan 29, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jan 28, 2018

See comment. Sometimes symlinks may not be created correctly and show a warning like this:

/plugins/TestRunner/Commands/TestsSetupFixture.php(160): Warning - symlink(): No such file or directory

This happens when the symlink points to a not existing file. Instead we try to "repair" the symlink by removing the original symlink and setting the correct path.

@tsteur tsteur added c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Needs Review PRs that need a code review labels Jan 28, 2018
@tsteur tsteur merged commit 339450a into 3.x-dev Jan 29, 2018
@tsteur tsteur deleted the testfixturesymlinks branch January 29, 2018 18:50
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants