Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visualization cleanup #125

Merged
merged 16 commits into from Oct 14, 2013
Merged

Visualization cleanup #125

merged 16 commits into from Oct 14, 2013

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 14, 2013

No description provided.

@tsteur
Updating submodules
670b86a
@tsteur
there is no longer a need for the properties class
1a3f5e0
@tsteur
properties class does no longer exist
fcafd47
@tsteur
phpdoc
341a06c
@tsteur
there is no need to overwrite the init method
b9be38d
@tsteur
fix most metrics are not translated, there is no need to reset those …
8e2f003 
…variables as they are already preconfigured in config class
@tsteur
get visualization properties from config
a9e10ed
@tsteur
trying to get rid of viewProperties
5b50214
@tsteur
now that we have a request and a config data object, this wording mig…
f390bec 
…ht be a bit clearer
@tsteur
I want to get rid of as many class properties as possible, view does …
92886bd 
…not have to be a class property
@tsteur
avoid usage of ViewDataTable
840c6c8
@tsteur
property is defined twice
9acbf3f
@tsteur
fix UI test by setting a fixed end date, otherwise we have to update …
569150e 
…the screenshot all the time
@tsteur
added interface for dataTable to be able to define the expected type …
dd44370 
…in a function, maybe it makes sense to add/remove some methods from the interface?
@tsteur
cloud works only with DataTable not with a map
ba9d56d
@tsteur
fix var name
4d35d70
tsteur added a commit that referenced this pull request Oct 14, 2013
@tsteur
Merge pull request #125 from piwik/visualization_cleanup
f8ac3f0 
Visualization cleanup
@tsteur tsteur merged commit f8ac3f0 into master Oct 14, 2013
@tsteur tsteur deleted the visualization_cleanup branch October 14, 2013 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tsteur