Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discard idGoal parameter for row evolution in goal visualizations #12378

Merged
merged 2 commits into from Apr 23, 2018

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 20, 2017

replaces #12195
refs #11526

@sgiehl sgiehl added the Needs Review PRs that need a code review label Dec 20, 2017
@sgiehl sgiehl added this to the 3.2.2 milestone Dec 20, 2017
@sgiehl sgiehl requested a review from tsteur December 20, 2017 16:34
@sgiehl sgiehl force-pushed the goalrowevolution branch 2 times, most recently from 3866026 to 68f1f01 Compare January 12, 2018 11:21
@sgiehl sgiehl force-pushed the goalrowevolution branch 2 times, most recently from f2b81e3 to c8ed70c Compare March 11, 2018 22:01
@sgiehl sgiehl force-pushed the goalrowevolution branch 2 times, most recently from 70d67a4 to 61e12e3 Compare March 21, 2018 19:40
@sgiehl sgiehl force-pushed the goalrowevolution branch 2 times, most recently from d9bbee7 to 591c2c9 Compare April 1, 2018 16:40
@mattab mattab modified the milestones: 3.6.0, 3.5.0 Apr 9, 2018
@mattab
Copy link
Member

mattab commented Apr 23, 2018

Thanks for the PR @sgiehl
would it be somehow possible to add a UI test reproducing the error from #11526 ?

@sgiehl
Copy link
Member Author

sgiehl commented Apr 23, 2018

@mattab I've added a UI test that opens one of the row evolutions that didn't work before...

@mattab mattab merged commit 12f4519 into 3.x-dev Apr 23, 2018
@sgiehl sgiehl deleted the goalrowevolution branch April 26, 2018 20:19
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
…tomo-org#12378)

* Discard idGoal parameter for row evolution in goal visualizations

* Adds UI test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants