New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show information in visitor profile if dataset was "truncated" #12376
Conversation
5b39a03
to
3881eec
Compare
3881eec
to
2ce08be
Compare
e597b2d
to
71c9240
Compare
71c9240
to
c05e909
Compare
3664cea
to
db820a6
Compare
System test is failing ( |
Not sure why, but |
found the issue, it's caused by the limit in the inner query: https://github.com/matomo-org/matomo/blob/3.x-dev/plugins/Live/Model.php#L264-L268 FOUND_ROWS() will always be limited by that, I guess. @sgiehl is this something you noticed? or was it working for you? |
Guess that worked in my tests, as the datasets were smaller than the |
…isits than shown in the summary
LGTM 👍 |
…"" (#12761) * Revert "Fix syntax vor 'SHOW COLUMNS FROM' (#12759)" This reverts commit f69c1f6. * Revert "fix #12722 (#12756)" This reverts commit 6c3ed18. * Revert "When setting or resetting User ID, do not update the Visitor ID in the first party cookie (#12742)" This reverts commit fdb161b. * Revert "Show information in visitor profile if dataset was "truncated" (#12376)" This reverts commit 14ba6a4.
…o-org#12376) * Show overall visit count in visitor profile if there have been more visits than shown in the summary * update/ add tests
…"" (matomo-org#12761) * Revert "Fix syntax vor 'SHOW COLUMNS FROM' (matomo-org#12759)" This reverts commit f69c1f6. * Revert "fix matomo-org#12722 (matomo-org#12756)" This reverts commit 6c3ed18. * Revert "When setting or resetting User ID, do not update the Visitor ID in the first party cookie (matomo-org#12742)" This reverts commit fdb161b. * Revert "Show information in visitor profile if dataset was "truncated" (matomo-org#12376)" This reverts commit 14ba6a4.
Shown visits in visitor profile is currently limited by
live_visitor_profile_max_visits_to_aggregate
(default 100). As some users might exceed this limit it would be helpful to show at least a message that the summary only represents the last X visits.based on #12375
refs #12373