Deprecates the historyService along with broadcast.init, broadcast.propagateAjax, broadcast.pageLoad
#12363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
added
the
Pull Request WIP
sgiehl
commented
Dec 16, 2017
| // init broadcast if not already done (it is required to make popovers work in widgetize mode) | ||
| if (broadcast.isWidgetizedDashboard()) { | ||
| broadcast.init(true); | ||
| } |
There was a problem hiding this comment.
adding <div piwik-popover-handler></div> in the widgetized dashboard template makes this no longer required
sgiehl
removed
the
Pull Request WIP
sgiehl
force-pushed
the
broadcast
branch
2 times, most recently
from
475d10d
to
4dd7231
Compare
sgiehl
force-pushed
the
broadcast
branch
2 times, most recently
from
313a574
to
0d891f0
Compare
sgiehl
force-pushed
the
broadcast
branch
2 times, most recently
from
82a162e
to
909fb0b
Compare
prevents reloading data when opening a popover
diosmosis
approved these changes
Jun 17, 2018
mattab
added
the
c: Platform
InfinityVoid
pushed a commit
to InfinityVoid/matomo
that referenced
this pull request
Oct 11, 2018
…st.propagateAjax`, `broadcast.pageLoad` (matomo-org#12363) * deprecates broadcast.propagateAjax() * make overlay js independed from history service and some broadcast methods * deprecates historyService alogn with some broadcast methods * make popovers work in widgetized dashboard without history service * do not update overlay page/sidebar when iframe url didn't change prevents reloading data when opening a popover
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
those methods have been used by overlay and in widgetized dashboard only and should now not be used anywhere
refs #6037