New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecates the historyService
along with broadcast.init
, broadcast.propagateAjax
, broadcast.pageLoad
#12363
Conversation
// init broadcast if not already done (it is required to make popovers work in widgetize mode) | ||
if (broadcast.isWidgetizedDashboard()) { | ||
broadcast.init(true); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding <div piwik-popover-handler></div>
in the widgetized dashboard template makes this no longer required
475d10d
to
4dd7231
Compare
313a574
to
0d891f0
Compare
82a162e
to
909fb0b
Compare
prevents reloading data when opening a popover
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested overlay locally + popovers in widgetized dashboard, appears to work as before.
…st.propagateAjax`, `broadcast.pageLoad` (matomo-org#12363) * deprecates broadcast.propagateAjax() * make overlay js independed from history service and some broadcast methods * deprecates historyService alogn with some broadcast methods * make popovers work in widgetized dashboard without history service * do not update overlay page/sidebar when iframe url didn't change prevents reloading data when opening a popover
those methods have been used by overlay and in widgetized dashboard only and should now not be used anywhere
refs #6037