Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename metrics that start with "Total" and remove the word Total #12359

Closed
mattab opened this issue Dec 14, 2017 · 2 comments
Closed

Rename metrics that start with "Total" and remove the word Total #12359

mattab opened this issue Dec 14, 2017 · 2 comments
Milestone
Backlog (Help wan...

Comments

@mattab
Copy link
Member

mattab commented Dec 14, 2017

For compability with Custom Reports, which prepends the word "Total" to metrics in some cases, we would like to remove the word "Total" that is sometimes prepended to our metric names. Here are the metrics that have the word Total and that we should rename (several plugins are affected).

total metrics

Notes / exceptions

  • Total value should be renamed to Event value
  • Also rename Maximum value to Maximum Event value
  • Also rename Minimum value to Minimum Event value
@mattab mattab added this to the 3.2.2 milestone Dec 14, 2017
@tsteur
Copy link
Member

tsteur commented Jan 17, 2018

The media analytics metrics are renamed (no new version released yet)

@ghost ghost mentioned this issue Jan 17, 2018
Merged
@mattab
Copy link
Member Author

mattab commented Jan 18, 2018

Fixed in #12460

@mattab mattab closed this as completed Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
2 participants
@tsteur @mattab