Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding some more did you know sections #12356

Merged
merged 1 commit into from Mar 20, 2018
Merged

Adding some more did you know sections #12356

merged 1 commit into from Mar 20, 2018

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 14, 2017

Feel free to tweak the wording.

@tsteur tsteur added the Needs Review PRs that need a code review label Dec 14, 2017
@tsteur tsteur added this to the 3.2.2 milestone Dec 14, 2017
@mattab mattab modified the milestones: 3.4.0, 3.3.1 Mar 19, 2018
@diosmosis
Copy link
Member

diosmosis commented Mar 20, 2018 •
edited

LGTM (I'm assuming the new events do not need docs)

EDIT: there may be some UI test failures, but will have to wait for the build to run again to see

@mattab mattab merged commit edfc875 into 3.x-dev Mar 20, 2018
@mattab mattab deleted the promotions branch March 20, 2018 10:11
InfinityVoid pushed a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018
@tsteur @InfinityVoid
Adding some more did you know sections (matomo-org#12356)
ec9de59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tsteur @diosmosis @mattab