Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When general settings admin is disabled, do not show archive settings #12343

Merged
merged 1 commit into from Dec 9, 2017

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Dec 8, 2017

The currently shown settings are wrong anyway (eg it always says YES browser archiving is enabled and shows how often it is archived but both values may be very wrong). Also it is not needed to show this information when the admin is disabled.

The currently shown settings are wrong anyway (eg it always says YES browser archiving is enabled and shows how often it is archived but both values may be very wrong). Also it is not needed to show this information when the admin is disabled.
@tsteur tsteur added the Needs Review PRs that need a code review label Dec 8, 2017
@tsteur tsteur added this to the 3.2.2 milestone Dec 8, 2017
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsteur tsteur merged commit 68141dd into 3.x-dev Dec 9, 2017
@tsteur tsteur deleted the generalsettingsadminarchive branch December 9, 2017 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants